-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problem: rpc stream overhead even if not used #551
Conversation
Solution: - init the underlying subscriptions lazily.
Signed-off-by: yihuang <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #551 +/- ##
========================================
Coverage 46.16% 46.17%
========================================
Files 181 181
Lines 18125 18124 -1
========================================
Hits 8368 8368
+ Misses 9040 9039 -1
Partials 717 717
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need skip PendingTxListener as well?
good catch, let's ignore pending tx listener here, it's feed by check-tx ante handler, which don't block state machine. the overhead of the other subscriptions are in the block commit flow. |
Solution:
Closes: #XXX
Description
For contributor use:
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerFor admin use:
WIP
,R4R
,docs
, etc)