Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: state overwrite not work in debug trace API #545

Merged
merged 3 commits into from
Oct 22, 2024

Conversation

mmsqe
Copy link
Collaborator

@mmsqe mmsqe commented Oct 21, 2024

Closes: #XXX

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@mmsqe mmsqe marked this pull request as ready for review October 22, 2024 01:49
@mmsqe mmsqe requested a review from yihuang October 22, 2024 01:49
Copy link

codecov bot commented Oct 22, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 46.19%. Comparing base (816389c) to head (305a1fa).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
x/evm/keeper/state_transition.go 69.23% 3 Missing and 1 partial ⚠️
x/evm/statedb/statedb.go 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #545      +/-   ##
===========================================
- Coverage    46.60%   46.19%   -0.42%     
===========================================
  Files          181      181              
  Lines        14526    18112    +3586     
===========================================
+ Hits          6770     8366    +1596     
- Misses        7036     9029    +1993     
+ Partials       720      717       -3     
Files with missing lines Coverage Δ
x/evm/keeper/statedb.go 84.92% <ø> (+1.13%) ⬆️
x/evm/statedb/statedb.go 77.83% <0.00%> (-0.69%) ⬇️
x/evm/keeper/state_transition.go 69.23% <69.23%> (-3.41%) ⬇️

... and 169 files with indirect coverage changes

@mmsqe mmsqe merged commit 4300682 into crypto-org-chain:develop Oct 22, 2024
37 of 39 checks passed
mmsqe added a commit that referenced this pull request Nov 4, 2024
* Problem: state overwrite not work in debug trace API

* test

* fix
@yihuang yihuang deleted the fix_trace branch November 5, 2024 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants