Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: gasUsed, gasLimit and bloom are not aligned in subscribe newHeads #544

Closed
wants to merge 2 commits into from

Merge branch 'develop' into align_head

10fe05d
Select commit
Loading
Failed to load commit list.
Closed

Problem: gasUsed, gasLimit and bloom are not aligned in subscribe newHeads #544

Merge branch 'develop' into align_head
10fe05d
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 18, 2024 in 0s

46.12% (-0.49%) compared to 816389c

View this Pull Request on Codecov

46.12% (-0.49%) compared to 816389c

Details

Codecov Report

Attention: Patch coverage is 34.42623% with 40 lines in your changes missing coverage. Please review.

Project coverage is 46.12%. Comparing base (816389c) to head (10fe05d).

Files with missing lines Patch % Lines
rpc/stream/rpc.go 0.00% 34 Missing ⚠️
rpc/backend/utils.go 86.36% 2 Missing and 1 partial ⚠️
rpc/backend/blocks.go 50.00% 1 Missing and 1 partial ⚠️
server/json_rpc.go 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #544      +/-   ##
===========================================
- Coverage    46.60%   46.12%   -0.49%     
===========================================
  Files          181      181              
  Lines        14526    18159    +3633     
===========================================
+ Hits          6770     8376    +1606     
- Misses        7036     9062    +2026     
- Partials       720      721       +1     
Files with missing lines Coverage Δ
server/json_rpc.go 0.00% <0.00%> (ø)
rpc/backend/blocks.go 77.95% <50.00%> (-3.03%) ⬇️
rpc/backend/utils.go 50.41% <86.36%> (+0.69%) ⬆️
rpc/stream/rpc.go 0.00% <0.00%> (ø)

... and 168 files with indirect coverage changes