Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: node can't quit by signal #543

Merged
merged 4 commits into from
Oct 17, 2024
Merged

Conversation

yihuang
Copy link
Collaborator

@yihuang yihuang commented Oct 17, 2024

Solution:

  • cleanup graceful shutdown procedure

Closes: #XXX

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

Solution:
- cleanup graceful shutdown procedure
@yihuang yihuang requested a review from mmsqe October 17, 2024 09:12
CHANGELOG.md Outdated Show resolved Hide resolved
Signed-off-by: yihuang <[email protected]>
Copy link

codecov bot commented Oct 17, 2024

Codecov Report

Attention: Patch coverage is 0% with 33 lines in your changes missing coverage. Please review.

Project coverage is 46.60%. Comparing base (a2ad87c) to head (139eb3e).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
server/json_rpc.go 0.00% 17 Missing ⚠️
server/start.go 0.00% 13 Missing ⚠️
testutil/network/util.go 0.00% 2 Missing ⚠️
testutil/network/network.go 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #543      +/-   ##
===========================================
+ Coverage    46.55%   46.60%   +0.05%     
===========================================
  Files          181      181              
  Lines        14542    14526      -16     
===========================================
  Hits          6770     6770              
+ Misses        7052     7036      -16     
  Partials       720      720              
Files with missing lines Coverage Δ
testutil/network/network.go 0.00% <0.00%> (ø)
testutil/network/util.go 0.00% <0.00%> (ø)
server/start.go 19.79% <0.00%> (+0.83%) ⬆️
server/json_rpc.go 0.00% <0.00%> (ø)

@yihuang yihuang enabled auto-merge (squash) October 17, 2024 13:02
@yihuang yihuang merged commit 816389c into crypto-org-chain:develop Oct 17, 2024
37 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants