Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: unsuppored sign mode SIGN_MODE_TEXTUAL in bank transfer #537

Merged
merged 2 commits into from
Oct 4, 2024

Conversation

mmsqe
Copy link
Collaborator

@mmsqe mmsqe commented Oct 4, 2024

Closes: #XXX

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@mmsqe mmsqe requested a review from yihuang October 4, 2024 01:06
Copy link

codecov bot commented Oct 4, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 46.56%. Comparing base (5acb559) to head (970285e).
Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
app/app.go 83.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #537      +/-   ##
===========================================
+ Coverage    46.45%   46.56%   +0.10%     
===========================================
  Files          181      181              
  Lines        14477    14506      +29     
===========================================
+ Hits          6725     6754      +29     
+ Misses        7045     7037       -8     
- Partials       707      715       +8     
Files with missing lines Coverage Δ
app/app.go 76.38% <83.33%> (+0.14%) ⬆️

... and 2 files with indirect coverage changes

@mmsqe mmsqe enabled auto-merge (squash) October 4, 2024 01:24
@mmsqe mmsqe merged commit c4cef0f into crypto-org-chain:develop Oct 4, 2024
37 of 39 checks passed
@yihuang yihuang deleted the textual branch October 4, 2024 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants