Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: native fee handler don't respect DefaultPriorityReduction #422

Merged
merged 3 commits into from
Mar 13, 2024

Conversation

yihuang
Copy link
Collaborator

@yihuang yihuang commented Mar 13, 2024

Solution:

  • vendor fee deduct decorator
  • a little refactor to remove DeductTxCostsFromUserBalance and call the DeductFees directly

next: will modify the DeductFees to provide a different impl for parallel exec

Apply suggestions from code review

Signed-off-by: yihuang [email protected]

fixes

fix err

fix lint

Closes: #XXX

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

Solution:
- vendor fee deduct decorator
- a little refactor to remove `DeductTxCostsFromUserBalance` and call the DeductFees directly

next: will modify the DeductFees to provide a different impl for parallel exec

Apply suggestions from code review

Signed-off-by: yihuang <[email protected]>

fixes

fix err

fix lint
@yihuang yihuang requested a review from mmsqe March 13, 2024 01:25
@yihuang
Copy link
Collaborator Author

yihuang commented Mar 13, 2024

somehow the old PR don't sync commits.

Copy link

codecov bot commented Mar 13, 2024

Codecov Report

Attention: Patch coverage is 59.37500% with 39 lines in your changes are missing coverage. Please review.

Project coverage is 63.31%. Comparing base (9e8e823) to head (2715497).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #422      +/-   ##
===========================================
- Coverage    63.36%   63.31%   -0.05%     
===========================================
  Files          129      130       +1     
  Lines        12252    12342      +90     
===========================================
+ Hits          7763     7814      +51     
- Misses        3986     4014      +28     
- Partials       503      514      +11     
Files Coverage Δ
app/ante/eip712.go 59.90% <100.00%> (ø)
app/ante/handler_options.go 77.94% <100.00%> (ø)
app/ante/fee_checker.go 91.00% <57.14%> (-2.75%) ⬇️
x/evm/keeper/utils.go 83.72% <70.00%> (-2.00%) ⬇️
app/ante/nativefee.go 57.14% <57.14%> (ø)

@yihuang yihuang merged commit 27d29cc into crypto-org-chain:develop Mar 13, 2024
36 of 39 checks passed
@yihuang yihuang deleted the share-deduct-fee branch March 13, 2024 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants