-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problem: don't support native action in statedb #333
Conversation
Signed-off-by: yihuang <[email protected]>
for key, store := range cms.stores { | ||
stores[key] = store.Clone() | ||
} |
Check failure
Code scanning / gosec
the value in the range statement should be _ unless copying a map: want: for key := range m Error
for _, store := range cms.stores { | ||
store.Write() | ||
} |
Check failure
Code scanning / gosec
the value in the range statement should be _ unless copying a map: want: for key := range m Error
for _, key := range keys { | ||
stores[key] = parent.GetKVStore(key) | ||
} |
Check failure
Code scanning / gosec
the value in the range statement should be _ unless copying a map: want: for key := range m Error
for key, store := range cms.stores { | ||
otherStore, ok := ms.stores[key] | ||
if !ok { | ||
panic("Invariant violation: Restore should only be called on a store cloned from itself") | ||
} | ||
store.Restore(otherStore) | ||
} |
Check failure
Code scanning / gosec
the value in the range statement should be _ unless copying a map: want: for key := range m Error
for key, store := range stores { | ||
if cms.TracingEnabled() { | ||
tctx := cms.traceContext.Clone().Merge(types.TraceContext{ | ||
storeNameCtxKey: key.Name(), | ||
}) | ||
|
||
store = tracekv.NewStore(store, cms.traceWriter, tctx) | ||
} | ||
cms.stores[key] = cachekv.NewStore(store) | ||
} |
Check failure
Code scanning / gosec
the value in the range statement should be _ unless copying a map: want: for key := range m Error
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
might need add store to default.nix
- (evm) crypto-org-chain#328 Support precompile interface. - (statedb) crypto-org-chain#333 Support native action in statedb, prepare for precompiles. - (precompile) crypto-org-chain#338 Fix simulation of precompile using context. - (precompile) crypto-org-chain#342 Problem: native action don't support mem keys - (precompile) crypto-org-chain#343 Problem: no api to convert native events to logs - (precompile) crypto-org-chain#344 Fix error handling in precompile context. - (precompile) crypto-org-chain#346 Add support for new precompile context. - (precompile) crypto-org-chain#347 Problem: miss contract in ExtStateDB interface - (precompile) crypto-org-chain#359 Problem: no efficient way to execute read-only native actions - (precompile) crypto-org-chain#371 Add StateDB itself into native context for precompiles to emit evm logs directly. - (precompile) crypto-org-chain#380 Allow init precompiled contract with rules when new evm.
Closes: #XXX
Description
For contributor use:
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerFor admin use:
WIP
,R4R
,docs
, etc)