Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(ci): submodule should sign commits #90

Merged
merged 2 commits into from
Sep 27, 2023

Conversation

aali309
Copy link
Contributor

@aali309 aali309 commented Sep 20, 2023

reference: #916

Copy link
Member

@tthvo tthvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just need the key to be generated.

@andrewazores andrewazores merged commit b7de47b into cryostatio:main Sep 27, 2023
4 checks passed
@tthvo
Copy link
Member

tthvo commented Oct 6, 2023

@Mergifyio backport gh-pages

@mergify
Copy link
Contributor

mergify bot commented Oct 6, 2023

backport gh-pages

❌ Command disallowed due to command restrictions in the Mergify configuration.

  • sender-permission>=write

@tthvo
Copy link
Member

tthvo commented Oct 6, 2023

Ahh nvmind I don't have permissions^^ But we need to backport this into gh-pages as in #89

@ebaron
Copy link
Member

ebaron commented Oct 10, 2023

Thanks @tthvo! I wonder if this is some kind of default setting with Mergify?

@ebaron
Copy link
Member

ebaron commented Oct 10, 2023

@Mergifyio backport gh-pages

@mergify
Copy link
Contributor

mergify bot commented Oct 10, 2023

backport gh-pages

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Oct 10, 2023
@aali309 aali309 deleted the submoduleShouldSignCommits branch October 10, 2023 13:59
@tthvo
Copy link
Member

tthvo commented Oct 10, 2023

Thanks @tthvo! I wonder if this is some kind of default setting with Mergify?

Yeh exactly! https://docs.mergify.com/commands/restrictions/#command-restriction-format

@ebaron
Copy link
Member

ebaron commented Oct 10, 2023

Thanks @tthvo! I wonder if this is some kind of default setting with Mergify?

Yeh exactly! https://docs.mergify.com/commands/restrictions/#command-restriction-format

Perhaps we want something along these lines instead:

commands_restrictions:
  backport:
    conditions:
      - sender=@team

@tthvo
Copy link
Member

tthvo commented Oct 10, 2023

Right! Thanks! I will make a new issue for this ^^

ebaron pushed a commit that referenced this pull request Oct 11, 2023
(cherry picked from commit b7de47b)

Co-authored-by: Atif Ali <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants