-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(scripts): add scripts to ease local chart testing #196
test(scripts): add scripts to ease local chart testing #196
Conversation
andrewazores
commented
Sep 6, 2024
- test(ct): add utility script for running ct locally
- add script for running connection tests
7b96c8f
to
9ed0379
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sense to convert these into a Makefile
?
I could, but I think it would mostly end up being just inline shell commands anyway, so I don't know how much that would really gain. |
Ah okayy! I was just thinking Makefile could define some targets that install the chart for some scenarios (i.e. port-forward, with route, with ingress, etc) to help with testing. |
It could, but unless there is a particular reason to use a Makefile, I'd rather not :-) if it adds something useful on top of bash scripts then yes, or else if it's also going to provide conventional |
Oh alright! I got no specific reasons to use Makefile (just very used to have them around^^). Otherwise, bash scripts sound good to me :D |
This reverts commit 1f9c7b0.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good^^