fix(urls): use relative Grafana ext url, remove unused storage ext url #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebaron
reviewed
Jun 7, 2024
|
Yes I suppose so |
ebaron
reviewed
Jun 7, 2024
There was a problem hiding this comment.
I think we still need the ROUTE_HOST part for NOTES.txt
$ helm install cryostat ./charts/cryostat/ --set core.route.enabled=true,authentication.openshift.enabled=true
NAME: cryostat
LAST DEPLOYED: Fri Jun 7 16:44:23 2024
NAMESPACE: helm-test
STATUS: deployed
REVISION: 1
NOTES:
- Tell Cryostat how to serve external traffic:
No actions required with this configuration.
- Visit the Cryostat application at:
echo https://$ROUTE_HOST$ echo https://$ROUTE_HOST
https://
andrewazores
force-pushed
the
relative-ext-url
branch
from
44748c2
to
9ba9a12
Compare
ebaron
approved these changes
Jun 7, 2024
andrewazores
added a commit
that referenced
this pull request
Jun 7, 2024
#145) (#151) * fix(storage): remove unused STORAGE_EXT_URL env var * use relative grafana dashboard ext url * update post-install notes * replace $ROUTE_HOST (cherry picked from commit 4d14d68) Co-authored-by: Andrew Azores <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See cryostatio/cryostat-operator#874