Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(storage): remove storage volume parameter overrides #130

Merged
merged 1 commit into from
May 21, 2024

Conversation

andrewazores
Copy link
Member

@andrewazores andrewazores commented Apr 10, 2024

Depends on #127
Based on #127
See cryostatio/cryostat-storage#14

Remove SeaweedFS volume tuning parameter overrides.

To test:

$ helm install cryostat --set authentication.openshift.enabled=true --set core.route.enabled=true --set openshiftOauthProxy.image.repository=quay.io/andrewazores/openshift-oauth-proxy --set openshiftOauthProxy.image.tag=test-14 --set authentication.basicAuth.enabled=true --set authentication.basicAuth.secretName=basicauth --set authentication.basicAuth.filename=htpasswd.conf --set storage.image.repository=quay.io/andrewazores/cryostat-storage --set storage.image.tag=volume-tuning-1 --set pvc.enabled=true --set pvc.storage=2Gi ./charts/cryostat/

This installs the Helm chart with an openshift-oauth-proxy (not actually required for this change to work, but it's how I tested it) and with a storage container built from cryostatio/cryostat-storage#14 . It requests a 2Gi PVC, but depending on the cluster the actual provisioned storage may be larger.

I then opened the web UI, defined a localhost:0 custom target for Cryostat to be able to monitor itself, and manually started a continuous flight recording with the ALL meta-template.

Then I ran the following:

$ while true; do curl -k 'https://user:[email protected]/api/v3/targets/1/recordings/1' --compressed -X PATCH -H 'Accept: */*' -H 'Accept-Encoding: gzip, deflate, br' -H 'Content-Type: text/plain;charset=UTF-8' --data-raw SAVE; sleep 10; done

So every 10 seconds, the script will fire a curl to ask Cryostat to archive that recording. Then I opened the Archives > All Archives view in the web UI, and from my OpenShift cluster's console I opened the Storage > PersistentVolumeClaims view and ensured that as new archived recordings were created that the PVC utilization increased by roughly the same amount (a little more to account for associated metadata). I also used oc exec -it cryostat-pod -c cryostat-storage /bin/bash to inspect the contents of the PVC directly with df -h and ls -l /data.

@andrewazores andrewazores marked this pull request as ready for review April 10, 2024 14:57
@andrewazores andrewazores added the chore Refactor, rename, cleanup, etc. label Apr 10, 2024
@andrewazores andrewazores marked this pull request as draft April 15, 2024 19:45
@andrewazores
Copy link
Member Author

Need to check on this bug before merging this: cryostatio/cryostat#370

@andrewazores andrewazores marked this pull request as ready for review April 17, 2024 14:02
@andrewazores
Copy link
Member Author

@ebaron should be ready now since cryostatio/cryostat-storage#15

@ebaron ebaron merged commit 1ab83ff into cryostatio:cryostat3 May 21, 2024
2 checks passed
@andrewazores andrewazores deleted the cryostat3-volume-tuning branch May 22, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Refactor, rename, cleanup, etc. safe-to-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants