Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MnC #218

Merged
merged 7 commits into from
Dec 22, 2024
Merged

Add MnC #218

merged 7 commits into from
Dec 22, 2024

Conversation

Samirkhairati
Copy link
Contributor

No description provided.

@skoriop skoriop changed the title Add-MnC-data Add MnC Dec 22, 2024
@skoriop skoriop self-requested a review December 22, 2024 13:09
skoriop
skoriop previously approved these changes Dec 22, 2024
Copy link
Member

@skoriop skoriop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but one caveat: we're still not sure about which semester EVS and PoE / PoM is supposed to be in for Mathematics and Computing students.

However, since this does not matter for this semester's release and in the interest of time, we'll merge this for now and make changes (if we need to) in a separate PR.

@skoriop skoriop added ready Ready to be merged (used by our GitHub Actions pipeline) and removed ready Ready to be merged (used by our GitHub Actions pipeline) labels Dec 22, 2024
@skoriop skoriop added the ready Ready to be merged (used by our GitHub Actions pipeline) label Dec 22, 2024
@skoriop skoriop self-requested a review December 22, 2024 14:25
Copy link
Member

@skoriop skoriop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (2)

@skoriop skoriop added this pull request to the merge queue Dec 22, 2024
Merged via the queue into master with commit 2fcade9 Dec 22, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready Ready to be merged (used by our GitHub Actions pipeline)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants