fix: minor nitpicks

crux-bphc · Jul 24, 2024 · 3390ba2 · 3390ba2
1 parent e23e690
commit 3390ba2
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/backend/src/controllers/timetable/searchTimetable.ts b/backend/src/controllers/timetable/searchTimetable.ts
@@ -24,14 +24,14 @@ export const searchTimetable = async (req: Request, res: Response) => {
       headers: { "Content-Type": "application/json" },
     });
 
-    let timetables = await response.json();
+    const searchResults = await response.json();
 
     if (!response.ok) {
-      console.log("Error while searching timetable: ", timetables.error);
+      console.log("Error while searching timetable: ", searchResults.error);
       return res.status(500).json({ message: "Internal Server Error" });
     }
 
-    timetables = timetables.map(
+    const timetables = searchResults.map(
       (el: { timetable: Timetable; score: string }) => el.timetable,
     );
 

diff --git a/backend/src/controllers/timetable/updateChangedTimetable.ts b/backend/src/controllers/timetable/updateChangedTimetable.ts
@@ -271,8 +271,8 @@ export const updateChangedTimetable = async (req: Request, res: Response) => {
       console.log("Error while adding course to search service: ", err.message);
       return res.status(500).json({ message: "Internal Server Error" });
     }
-    // update timetables in search service
 
+    // update timetables in search service
     for (const timetable of timetables) {
       try {
         const searchServiceURL = `${env.SEARCH_SERVICE_URL}/timetable/remove`;
@@ -316,8 +316,8 @@ export const updateChangedTimetable = async (req: Request, res: Response) => {
             },
             body: JSON.stringify(timetableWithSectionsString),
           });
-          const resJson = await res.json();
           if (!res.ok) {
+            const resJson = await res.json();
             console.log(resJson.error);
           }
         } catch (err: any) {