Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#19: Fix empty filename #38

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

#19: Fix empty filename #38

wants to merge 1 commit into from

Conversation

dror-g
Copy link

@dror-g dror-g commented May 1, 2024

#19 Fixed using: file_name = stream_name

( 🤷‍♂️ works for me.. )

Fixed using: file_name = stream_name

(:man_shrugging: )
@ReubenFrankel
Copy link

I think you end up with the stream name twice in the file path here, since folder_path already includes the stream name.

folder_path = f"{self.bucket}/{self.prefix}/{stream_name}/"
file_name = stream_name

return f"{folder_path}{file_name}.{self.extension}.{self.compression}"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants