Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bucket: avoid crashing on malformed expression (fix #3351) #3368

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mmetc
Copy link
Contributor

@mmetc mmetc commented Dec 16, 2024

No description provided.

@mmetc mmetc added this to the 1.6.5 milestone Dec 16, 2024
Copy link

@mmetc: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind refactoring
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@mmetc mmetc changed the title bucket: avoid crashing on malformed expression bucket: avoid crashing on malformed expression (fix #3351) Dec 16, 2024
@mmetc mmetc added the kind/fix label Dec 16, 2024
Copy link

codecov bot commented Dec 16, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 58.37%. Comparing base (b1e2b95) to head (0b722bb).

Files with missing lines Patch % Lines
pkg/leakybucket/uniq.go 40.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3368      +/-   ##
==========================================
- Coverage   58.40%   58.37%   -0.04%     
==========================================
  Files         351      351              
  Lines       37879    37878       -1     
==========================================
- Hits        22125    22113      -12     
- Misses      13843    13850       +7     
- Partials     1911     1915       +4     
Flag Coverage Δ
bats 41.22% <40.00%> (-0.04%) ⬇️
unit-linux 34.37% <40.00%> (-0.02%) ⬇️
unit-windows 29.60% <40.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmetc mmetc marked this pull request as draft December 16, 2024 15:14
@mmetc
Copy link
Contributor Author

mmetc commented Dec 18, 2024

this has issues, we should compile on bucket load. see also #3371

@buixor buixor assigned buixor and blotus and unassigned buixor Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants