Skip to content
This repository has been archived by the owner on Apr 3, 2020. It is now read-only.

Update WinSDK.js to handle recursively translation files #151

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fernandolguevara
Copy link

@rakuco
Copy link

rakuco commented Jan 9, 2017

@darktears, @pozdnyakov, @baleboy: ping

@fernandolguevara: thanks for the patch. Can you be more descriptive in both the PR message and the commit message? Specifically, it would be good to explain what the problem was and what your patch does to fix it. Last but not least, it looks like you're using a different indentation than the rest of the code, so that needs to be fixed.

@fernandolguevara
Copy link
Author

@rakuco the problem is in the generation of wix file, the folder containing the translations also has sub folders with more translations files and the current code cant handle this, my patch fix that situation.

I found another issue , if you run the generation of msi file some times the new msi file contains the olders ...

@rakuco
Copy link

rakuco commented Jan 9, 2017

I see. My point with updating your messages is that this sort of information should be part of the PR and, most importantly, the commit, so that people using git log or git blame years from now will still be able to figure out why a certain commit was merged without having to backtrack to GitHub and then JIRA.

@fernandolguevara fernandolguevara force-pushed the patch-1 branch 2 times, most recently from 34c38aa to d9e6256 Compare January 9, 2017 16:49
@fernandolguevara fernandolguevara changed the title FIX XWALK-7420 Update WinSDK.js to handle recursively translation files Jan 9, 2017
@fernandolguevara
Copy link
Author

@rakuco done

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants