This repository has been archived by the owner on Jun 8, 2022. It is now read-only.
Update apply.go #232
Open
Update apply.go #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
如果自定义的scope 对象 第一次创建的时候， 没有加入spec字段， 会报错，此时不应该return， 而应该继续向下执行， 第一次patch 成功后， 这一段 pave 就不会报错，然后检查workload ref 是否重复。
ryanzhang-oss
suggested changes
Oct 8, 2020
| @@ -222,8 +222,10 @@ func (a *workloads) applyScope(ctx context.Context, wl Workload, s unstructured. | |||
| return nil | |||
| } | |||
| } | |||
| } else { | |||
| return errors.Wrapf(err, errFmtGetScopeWorkloadRef, s.GetAPIVersion(), s.GetKind(), s.GetName(), workloadRefsPath) | |||
| }else if err.Error() == "spec: no such field"{ | |||
There was a problem hiding this comment.
compare err with some magic string is an anti-pattern.
There was a problem hiding this comment.
We can't proceed if the workloadRef path is provided but doesn't work
|
AppConfig depends on the field path from ScopeDefinition's |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
如果自定义的scope 对象 第一次创建的时候， 没有加入spec字段， 会报错，此时不应该return， 而应该继续向下执行， 第一次patch 成功后， 这一段 pave 就不会报错，然后检查workload ref 是否重复。