Feature/add mongo user role resources #859
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knutejoh
requested review from
ulucinar,
sergenyalcin and
turkenf
as code owners
|
/test-examples="examples/cosmosdb/v1beta1/mongoroledefinition.yaml" |
1 similar comment
|
/test-examples="examples/cosmosdb/v1beta1/mongoroledefinition.yaml" |
|
/test-examples="examples/cosmosdb/v1beta1/mongouserdefinition.yaml" |
|
@turkenf @ulucinar @sergenyalcin @erhancagirici |
|
Hi @knutejoh, thank you for the contribution, could you please rebase your PR to the main and resolve the conflicts to move forward? |
Signed-off-by: Knut-Erik Johnsen <[email protected]>
Signed-off-by: Knut-Erik Johnsen <[email protected]>
Signed-off-by: Knut-Erik Johnsen <[email protected]>
knutejoh
force-pushed
the
feature/add-mongo-user-role-resources
branch
from
35f520a
to
a1967c0
Compare
|
/test-examples="examples/cosmosdb/v1beta1/mongoroledefinition.yaml" |
|
/test-examples="examples/cosmosdb/v1beta1/mongouserdefinition.yaml" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Added resources
azurerm_cosmosdb_mongo_role_definition
azurerm_cosmosdb_mongo_user_definition
Fixes #858
I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested
Test with kind as local cluster provisioning in Azure.