Draft: Add peek to ArrayQueue<T> where T: Copy #1013
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
After reviewing the miri tests, i'm not convinced this can be done without UB or substantially revising the algo... |
|
So after a bit of rework, I added a custom spinlock and was able to make miri happy locally. I'm skeptical if this is something that the crossbeam team will really be interested in since it requires an extra spinlock which will cause contention between |
taiki-e
reviewed
Aug 15, 2023
|
yep thanks for the consideration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi 👋 , I'm not sure if there is appetite in general for this feature but I personally found it useful. I would be happy to add the symmetric method to
SegQueueas well. I noticed issue #30 but I figured it does not apply to this specialization. Also happy to just leave this be if it's not useful to anyone.