Allow to run arbitrary commands in containers using cross-util run ... #1280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lumasepa
commented
Jun 22, 2023
lumasepa
force-pushed
the
feature/allow-to-run-arbitrary-commands
branch
from
1fb1f17 to
f09361c
Compare
lumasepa
changed the title
lumasepa
force-pushed
the
feature/allow-to-run-arbitrary-commands
branch
2 times, most recently
from
9623db9 to
278c3ea
Compare
lumasepa
force-pushed
the
feature/allow-to-run-arbitrary-commands
branch
from
278c3ea to
be92c3f
Compare
lumasepa
force-pushed
the
feature/allow-to-run-arbitrary-commands
branch
from
7e46941 to
00c39a6
Compare
|
The changelog check is failing, I added a line in the changelog. Any suggestions on how to fix it? |
|
See https://github.com/cross-rs/cross/blob/main/.changes/README.md for how to make a changelog entry :) |
Emilgardis
approved these changes
Jun 23, 2023
lumasepa
force-pushed
the
feature/allow-to-run-arbitrary-commands
branch
from
00c39a6 to
1aab4cf
Compare
Thanks, done 😄 |
Emilgardis
approved these changes
Jun 27, 2023
bors bot
added a commit
that referenced
this pull request
Jun 27, 2023
1280: Allow to run arbitrary commands in containers using cross-util run ... r=Emilgardis a=lumasepa Implementation for #1266 Co-authored-by: Sergio Medina <[email protected]>
Emilgardis
added
the
no-ci-targets
|
I keep forgetting some targets are broken... bors cancel bors r+ |
|
Canceled. |
|
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
Closed
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation for #1266