Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I made a small fix to your jquery-autoload fork #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

coredumperror
Copy link

I discovered that some browsers appear to have small differences in how they report the height and scrollTop values, so I added 20 pixels to the comparison, ensuring that there won't be a problem triggering the autoloader.

Thanks very much for making the initial fix; I hope you find my change useful!

… differences in different browsers don't break the autoload
@cristinawithout
Copy link
Owner

Thanks for checking this out.

Which browsers did you see an issue with? I'd like to take a look at it as well and test the solution.

@coredumperror
Copy link
Author

It's been a while, but I definitely recall it being a problem on desktop Chrome and the iOS 5 Simulator. There may have been more, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants