Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dz1 #15

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

dz1 #15

wants to merge 2 commits into from

Conversation

ejuo
Copy link

@ejuo ejuo commented Oct 29, 2012

jslint compatible.


arr.sort(sRand);

window.onload = (function () {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

window.onload получит undefined ибо тут IEFE (тутжевызванная функция), которая ничего не возвращает. Убери вызов функции и будет все хорошо.

А еще лучше делать так:

window.addEventListener('load', function () {
    'use strict';
    document.getElementById('arr').innerHTML = arr;
    document.getElementById('btn').addEventListener('click', function () { 
        document.getElementById('sarr').innerHTML = sBubble(arr); 
    }, false);
}, false);

Ну и назови arr и sarr каким-нибудь красивым и понятным всем именем. result или sort-result или еще как. sarr == http://www.footballtop.ru/players/mohamed-sarr

@azproduction
Copy link
Member

Ну вот - совсем другое дело :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants