Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.27] OCPBUGS-42910: Cherry-pick changes from containers/storage/pull#2134 #8679

Conversation

kwilczynski
Copy link
Member

What type of PR is this?

/kind bug
/assign kwilczynski

What this PR does / why we need it:

Manually cherry-pick changes from https://github.com/containers/storage/pull#2134 as these changes contain a fix that needs to be backported to CRI-O release 1.27, part of OpenShift 4.14 release.

Related:

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

None

@kwilczynski kwilczynski requested a review from mrunalp as a code owner October 15, 2024 10:26
@openshift-ci openshift-ci bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/bug Categorizes issue or PR as related to a bug. labels Oct 15, 2024
@openshift-ci openshift-ci bot requested review from klihub and QiWang19 October 15, 2024 10:27
@kwilczynski kwilczynski changed the title Cherry-pick changes from containers/storage/pull#2134 [release-1.27] Cherry-pick changes from containers/storage/pull#2134 Oct 15, 2024
@kwilczynski kwilczynski changed the title [release-1.27] Cherry-pick changes from containers/storage/pull#2134 [WIP] [release-1.27] Cherry-pick changes from containers/storage/pull#2134 Oct 15, 2024
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 15, 2024
@kwilczynski
Copy link
Member Author

/approve
/lgtm

Copy link
Contributor

openshift-ci bot commented Oct 15, 2024

@kwilczynski: you cannot LGTM your own PR.

In response to this:

/approve
/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

openshift-ci bot commented Oct 15, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kwilczynski
Once this PR has been reviewed and has the lgtm label, please assign umohnani8 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kwilczynski kwilczynski changed the title [WIP] [release-1.27] Cherry-pick changes from containers/storage/pull#2134 [WIP] [release-1.27] OCPBUGS-42910: Cherry-pick changes from containers/storage/pull#2134 Oct 15, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 15, 2024
@openshift-ci-robot
Copy link

@kwilczynski: This pull request references Jira Issue OCPBUGS-42910, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected Jira Issue OCPBUGS-42910 to depend on a bug in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

What type of PR is this?

/kind bug
/assign kwilczynski

What this PR does / why we need it:

Manually cherry-pick changes from https://github.com/containers/storage/pull#2134 as these changes contain a fix that needs to be backported to CRI-O release 1.27, part of OpenShift 4.14 release.

Related:

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

None

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Oct 15, 2024
@kwilczynski kwilczynski force-pushed the feature/containers-storage-2134-to-release-1.27 branch 3 times, most recently from b52ad87 to 9b0391b Compare October 16, 2024 15:51
@kwilczynski
Copy link
Member Author

/retest

2 similar comments
@kwilczynski
Copy link
Member Author

/retest

@kwilczynski
Copy link
Member Author

/retest

@kwilczynski kwilczynski force-pushed the feature/containers-storage-2134-to-release-1.27 branch from 9b0391b to 68614ac Compare October 17, 2024 10:37
@kwilczynski kwilczynski changed the title [WIP] [release-1.27] OCPBUGS-42910: Cherry-pick changes from containers/storage/pull#2134 [release-1.27] OCPBUGS-42910: Cherry-pick changes from containers/storage/pull#2134 Oct 17, 2024
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 17, 2024
@kwilczynski
Copy link
Member Author

/jira refresh

@openshift-ci-robot
Copy link

@kwilczynski: This pull request references Jira Issue OCPBUGS-42910, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected Jira Issue OCPBUGS-42910 to depend on a bug in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@kwilczynski
Copy link
Member Author

/retest

Copy link
Contributor

openshift-ci bot commented Oct 20, 2024

@kwilczynski: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp 68614ac link true /test e2e-gcp
ci/prow/e2e-agnostic 68614ac link true /test e2e-agnostic
ci/prow/images 68614ac link true /test images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@kwilczynski
Copy link
Member Author

@cri-o/cri-o-maintainers, please have a look. Thank you!

@haircommander haircommander merged commit 7597c43 into cri-o:release-1.27 Oct 21, 2024
34 of 42 checks passed
@openshift-ci-robot
Copy link

@kwilczynski: Jira Issue OCPBUGS-42910: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-42910 has been moved to the MODIFIED state.

In response to this:

What type of PR is this?

/kind bug
/assign kwilczynski

What this PR does / why we need it:

Manually cherry-pick changes from https://github.com/containers/storage/pull#2134 as these changes contain a fix that needs to be backported to CRI-O release 1.27, part of OpenShift 4.14 release.

Related:

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

None

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@kwilczynski kwilczynski deleted the feature/containers-storage-2134-to-release-1.27 branch October 27, 2024 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes Indicates the PR's author has DCO signed all their commits. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. kind/bug Categorizes issue or PR as related to a bug. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants