Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ SMTP Authentication #80

Merged
merged 9 commits into from
Mar 24, 2024
Merged

✨ SMTP Authentication #80

merged 9 commits into from
Mar 24, 2024

Conversation

cfpwastaken
Copy link
Member

@cfpwastaken cfpwastaken commented Mar 23, 2024

Authentication for outgoing SMTP mail (MAIL FROM our host) as described in RFC 4954 and PLAIN authentication as described in RFC 4616.

image

@cfpwastaken cfpwastaken added the enhancement New feature or request label Mar 23, 2024
@cfpwastaken cfpwastaken self-assigned this Mar 23, 2024
src/smtp/SMTPServer.ts Fixed Show resolved Hide resolved
@cfpwastaken cfpwastaken marked this pull request as ready for review March 23, 2024 17:43
@cfpwastaken cfpwastaken requested a review from j0code March 23, 2024 17:44
Copy link
Member

@j0code j0code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one small tweak
will approve after

src/smtp/SMTPServer.ts Outdated Show resolved Hide resolved
@cfpwastaken cfpwastaken requested a review from j0code March 24, 2024 12:59
src/smtp/SMTPServer.ts Fixed Show fixed Hide fixed
src/smtp/SMTPServer.ts Fixed Show fixed Hide fixed
src/smtp/SMTPServer.ts Fixed Show fixed Hide fixed
src/smtp/SMTPServer.ts Fixed Show fixed Hide fixed
Copy link
Member

@j0code j0code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor changes

src/smtp/SMTPServer.ts Outdated Show resolved Hide resolved
src/smtp/SMTPServer.ts Outdated Show resolved Hide resolved
@cfpwastaken cfpwastaken requested a review from j0code March 24, 2024 13:47
@cfpwastaken cfpwastaken merged commit 6a799fd into main Mar 24, 2024
7 checks passed
@cfpwastaken cfpwastaken deleted the f-smtpauth branch October 6, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants