Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: minified issue on various components #827

Open
wants to merge 20 commits into
base: develop-fixed-dco
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
69b3087
fix: initial values of variales in usestate
pranalidhanavade Nov 26, 2024
d7e2a64
[Deno Deploy] Update .github/workflows/deploy.yml
deno-deploy[bot] Nov 26, 2024
bb60c17
fix: testing for react minified
pranalidhanavade Nov 26, 2024
082fbfa
Merge branch 'fix/minified-issue-on-various-components' of https://gi…
pranalidhanavade Nov 26, 2024
f0eab0a
fix: testing for reactminified
pranalidhanavade Nov 26, 2024
d4b526a
fix: testing for reactminified
pranalidhanavade Nov 26, 2024
3593255
fix: testing for react minified
pranalidhanavade Nov 26, 2024
69467ef
fix: react minified issue fixes
pranalidhanavade Nov 26, 2024
d916892
[Deno Deploy] Update .github/workflows/deploy.yml
deno-deploy[bot] Nov 27, 2024
8fbfac3
fix: initial values of variales in usestate
pranalidhanavade Nov 26, 2024
ff31bb9
fix: testing for react minified
pranalidhanavade Nov 26, 2024
c3778d3
[Deno Deploy] Update .github/workflows/deploy.yml
deno-deploy[bot] Nov 26, 2024
4afa96a
fix: testing for reactminified
pranalidhanavade Nov 26, 2024
5f1fa57
fix: testing for reactminified
pranalidhanavade Nov 26, 2024
f7fa3a9
fix: testing for react minified
pranalidhanavade Nov 26, 2024
7dd170b
fix: react minified issue fixes
pranalidhanavade Nov 26, 2024
0508903
refactor:removed consoles
pranalidhanavade Nov 27, 2024
a14dfc0
fix: sonarlint issues
pranalidhanavade Nov 27, 2024
31f5e86
fix-minified-issue-on-various-components
pranalidhanavade Nov 27, 2024
5d4ea3c
[Deno Deploy] Update .github/workflows/deploy.yml
deno-deploy[bot] Nov 27, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/deploy.yml
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
name: Deploy
on:
push:
branches: develop-fixed-dco
branches: fix/minified-issue-on-various-components
pull_request:
branches: develop-fixed-dco
branches: fix/minified-issue-on-various-components

jobs:
deploy:
Expand Down
12 changes: 6 additions & 6 deletions src/commonComponents/ConfirmationModal.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,10 @@ interface IProps {
onSuccess: (flag: boolean) => void;
message: string | ReactElement |React.ReactNode;
isProcessing: boolean;
success: string | null;
failure: string | null;
setFailure: (flag: string | null) => void;
setSuccess: (flag: string | null) => void;
success: string;
failure: string;
setFailure: (flag: string) => void;
setSuccess: (flag: string) => void;
buttonTitles: string[];
loading:boolean;
warning?:String
Expand Down Expand Up @@ -83,7 +83,7 @@ const ConfirmationModal = ({ openModal, closeModal, onSuccess, message, isProces
message={success}
type={'success'}
onAlertClose={() => {
setSuccess && setSuccess(null);
setSuccess && setSuccess('');
}}
/>
</div>
Expand All @@ -94,7 +94,7 @@ const ConfirmationModal = ({ openModal, closeModal, onSuccess, message, isProces
message={failure}
type={'failure'}
onAlertClose={() => {
setFailure && setFailure(null);
setFailure && setFailure('');
}}
/>
</div>
Expand Down
5 changes: 3 additions & 2 deletions src/commonComponents/DeviceDetailsCard.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -7,14 +7,15 @@ import type { AxiosResponse } from "axios";
import { apiStatusCodes } from "../config/CommonConstant";
import { dateConversion } from "../utils/DateConversion";
import DateTooltip from "../components/Tooltip";
import React from "react";

interface IResponseMessages {type: "error" | "success", message: string}

const DeviceDetails = (props: { deviceFriendlyName: string, createDateTime: string, credentialID: string, refreshList: () => void, disableRevoke: boolean, responseMessages: (value: IResponseMessages) => void }) => {
const [openModal, setOpenModal] = useState<boolean>(false);
const [openEditModel, setOpenEditModel] = useState<boolean>(false)
const [editSuccess, setEditSuccess] = useState<string | null>(null)
const [editfailure, setEditFailure] = useState<string | null>(null)
const [editSuccess, setEditSuccess] = useState<string>('')
const [editfailure, setEditFailure] = useState<string>('')
const handleDeleteModel = (flag: boolean) => {
setOpenModal(flag)
}
Expand Down
1 change: 1 addition & 0 deletions src/commonComponents/EditPopup.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import { Button, Label, Modal } from 'flowbite-react';
import { Field, Form, Formik } from 'formik';
import * as yup from 'yup';
import { useRef } from 'react';
import React from 'react';

const EditModal = (props: {
openModal: boolean;
Expand Down
8 changes: 4 additions & 4 deletions src/commonComponents/PasseyAddDevicePopup.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,9 @@ const PasskeyAddDevice = (props: {
registerWithPasskey: (flag: boolean) => Promise<void>
}
) => {
const [fidoUserError, setFidoUserError] = useState<string | null>(null)
const [fidoUserError, setFidoUserError] = useState<string>('')
const [nextflag, setNextFlag] = useState<boolean>(false)
const [success, setSuccess] = useState<string | null>(null)
const [success, setSuccess] = useState<string>('')
const [passwordVisible, setPasswordVisible] = useState(false);

const savePassword = async (values: PasswordValue) => {
Expand Down Expand Up @@ -60,8 +60,8 @@ const PasskeyAddDevice = (props: {
<Alert
color={success ? "success" : "failure"}
onDismiss={() => {
setSuccess(null)
setFidoUserError(null)
setSuccess('')
setFidoUserError('')
}
}
>
Expand Down
Loading