Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change linux default network-mode to user #4514

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

lilyLuLiu
Copy link
Contributor

@lilyLuLiu lilyLuLiu commented Dec 16, 2024

Currently, the Linux default network mode is system. But many issues happen due to different system situations.
For most user, user network mode already satisfied their demands. And user network mode no need to deal with complex system situations.
So after discuss, it's better to set user as default network-mode, making sure CRC works well in default.
If the user requires more functions, they can switch to system network mode.

@gbraad @praveenkumar @anjannath have agreed on this being needed.
It needs to start testing early during December.
In the worst case, we can revert before the new release in January.

@openshift-ci openshift-ci bot requested review from adrianriobo and gbraad December 16, 2024 08:09
Copy link

openshift-ci bot commented Dec 16, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign gbraad for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rohanKanojia
Copy link
Contributor

@lilyLuLiu : Hello, Could you please provide some context on why this change is needed?

@lilyLuLiu lilyLuLiu self-assigned this Dec 18, 2024
if runtime.GOOS == "linux" {
ch = "ssh://[email protected]:22/run/user/1000/podman/podman.sock"
}
*/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lilyLuLiu May be you should remove that completely instead just commenting out?

@@ -1,10 +1,10 @@
@proxy @linux
@proxy @linux
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is just extra space so better to remove it.

@praveenkumar
Copy link
Member

/retest

@praveenkumar
Copy link
Member

@lilyLuLiu About integration failure I think https://github.com/crc-org/crc/blob/main/pkg/crc/network/types.go#L65 is culprit because settings only apply if we build binary for non installer, we need to change the default here also

@lilyLuLiu lilyLuLiu force-pushed the linux-networkmode branch 2 times, most recently from 59b015f to 4626dd4 Compare December 24, 2024 08:07
Copy link

openshift-ci bot commented Dec 24, 2024

@lilyLuLiu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/integration-crc 5bcb9a2 link true /test integration-crc
ci/prow/e2e-crc 5bcb9a2 link true /test e2e-crc

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Work In Progress
Development

Successfully merging this pull request may close these issues.

3 participants