-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change linux default network-mode to user #4514
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
d4d23de
to
42bccc9
Compare
@lilyLuLiu : Hello, Could you please provide some context on why this change is needed? |
test/e2e/testsuite/testsuite.go
Outdated
if runtime.GOOS == "linux" { | ||
ch = "ssh://[email protected]:22/run/user/1000/podman/podman.sock" | ||
} | ||
*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lilyLuLiu May be you should remove that completely instead just commenting out?
test/e2e/features/proxy.feature
Outdated
@@ -1,10 +1,10 @@ | |||
@proxy @linux | |||
@proxy @linux |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change is just extra space so better to remove it.
/retest |
@lilyLuLiu About integration failure I think https://github.com/crc-org/crc/blob/main/pkg/crc/network/types.go#L65 is culprit because settings only apply if we build binary for non installer, we need to change the default here also |
59b015f
to
4626dd4
Compare
4626dd4
to
5bcb9a2
Compare
@lilyLuLiu: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Currently, the Linux default network mode is system. But many issues happen due to different system situations.
For most user, user network mode already satisfied their demands. And user network mode no need to deal with complex system situations.
So after discuss, it's better to set user as default network-mode, making sure CRC works well in default.
If the user requires more functions, they can switch to system network mode.
@gbraad @praveenkumar @anjannath have agreed on this being needed.
It needs to start testing early during December.
In the worst case, we can revert before the new release in January.