fix (machine) : crc daemon /status api should return correct preset value for okd cluster (#4478)

[rohanKanojia]

Fix #4478

Relates to: Issue #4478 #4479

Solution/Idea

CRC daemon's /api/status API endpoint should return correct value of preset when running CRC cluster configured with crc preset. At the moment it only returns correct value for microshift and openshift presets.

Proposed changes

• Refactor Status() method to move ClusterStatusResult object creation logic to a separate method for easier testing
• Add case for OKD preset while setting preset value in cluster preset

Testing

Build a development version of CRC and create a cluster configured with okd preset. Then query status endpoint to see what preset is returned by API server.

1. crc config set preset okd
2. crc setup
3. crc start
4. curl -i --unix-socket ~/.crc/crc-http.sock http://crc/api/status | jq .Preset should return "okd"

Old Behavior

Old Response of /api/status on OKD based cluster:

{
  "CrcStatus": "Running",
  "OpenshiftStatus": "Unreachable",
  "OpenshiftVersion": "4.14.0-0.okd-scos-2024-01-10-151818",
  "DiskUse": 16885141504,
  "DiskSize": 32680947712,
  "RAMUse": 1958576128,
  "RAMSize": 9371365376,
  "Preset": "openshift" // Not OK, should be okd
}

New Behavior (with this PR)

New Response of /api/status on OKD based cluster:

{
  "CrcStatus": "Running",
  "OpenshiftStatus": "Unreachable",
  "OpenshiftVersion": "4.15.0-0.okd-2024-02-23-163410",
  "DiskUse": 521195520,
  "DiskSize": 10947768320,
  "RAMUse": 21496344576,
  "RAMSize": 32680947712,
  "Preset": "okd"
}

I have tested by cherry-picking this commit on top of #4479 , it's now displaying OKD value in crc status as expected.

[openshift-ci]

Hi @rohanKanojia. Thanks for your PR.

I'm waiting for a crc-org member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[anjannath]

/ok-to-test

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anjannath

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [anjannath]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@rohanKanojia: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/integration-crc	691b143	link	true	/test integration-crc
ci/prow/e2e-crc	691b143	link	true	/test e2e-crc

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.