-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[QE] update github action for linux arm64 tests #4468
Conversation
faf1f37
to
4048dcb
Compare
35d9bcb
to
77aca32
Compare
hey @lilyLuLiu I added the WIP yesterday cause I was gonna take a look but saw those testing commits... so to mark the PR to no to check yet added the WIP |
@adrianriobo Thanks for the reminder. I mark this pr as draft. Will this close the checking running? If not, how can I stop the check? |
by check I meant myself checking / reviewing |
4c0073b
to
f636a6e
Compare
af192f9
to
abf9381
Compare
b585632
to
2756f24
Compare
@adrianriobo I have finished this code update. Could you please review it when you have time? Thanks |
1d0b191
to
0ce2c33
Compare
@lilyLuLiu: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
permissions: | ||
statuses: write # needed to update commit status (pending/failure/sucess) | ||
checks: write # as documented in https://github.com/mikepenz/action-junit-report?tab=readme-ov-file#pr-run-permissions | ||
steps: | ||
- name: Check out repository code |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are you cloning the code here? to get the bunble versions? If that is the case it will not work on the PR for the new bundles version.
This is b/c this is a workflow_run which is executed on the context of the default branch of the upstream repo which has actual verisons not the ones you set on the PR....
For this to work you need to pass that information on an artifact (as we do with images...)
But as this is an edge case feel free to create a following issue with this may @albfan can take a look at it...as is a minor chnage but it requires to know about how this testing strategy works.
beyond this LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
^^ @lilyLuLiu
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Adrian. Will fix this for a following pr.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adrianriobo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
#4326