-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(deps): bump github.com/golangci/golangci-lint from 1.61.0 to 1.62.0 in /tools #4452
build(deps): bump github.com/golangci/golangci-lint from 1.61.0 to 1.62.0 in /tools #4452
Conversation
Hi @dependabot[bot]. Thanks for your PR. I'm waiting for a crc-org member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This introduces 2 new lint errors
|
e34aaa5
to
9804aa0
Compare
/hold |
9804aa0
to
ea5338a
Compare
/unhold |
/lgtm |
@dependabot[bot]: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
golang 1.21.0 introduced a 'min' builtin function https://pkg.go.dev/[email protected]#min so we don't have to implement it ourselves. Also golint-1.62 complains if we are not using the builtin 'min'.
Bumps [github.com/golangci/golangci-lint](https://github.com/golangci/golangci-lint) from 1.61.0 to 1.62.0. - [Release notes](https://github.com/golangci/golangci-lint/releases) - [Changelog](https://github.com/golangci/golangci-lint/blob/master/CHANGELOG.md) - [Commits](golangci/golangci-lint@v1.61.0...v1.62.0) --- updated-dependencies: - dependency-name: github.com/golangci/golangci-lint dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
ea5338a
to
61b6041
Compare
Ah messed up my push, thanks! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cfergeau The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Bumps github.com/golangci/golangci-lint from 1.61.0 to 1.62.0.
Release notes
Sourced from github.com/golangci/golangci-lint's releases.
... (truncated)
Changelog
Sourced from github.com/golangci/golangci-lint's changelog.
Commits
22b58c9
build(deps): bump go-simpler.org/musttag from 0.12.2 to 0.13.0 (#5121)84c203a
build(deps): bump github.com/lasiar/canonicalheader from 1.1.1 to 1.1.2 (#5119)0f4f0cb
build(deps): bump golang.org/x/tools from 0.26.0 to 0.27.0 (#5120)02a536a
build(deps): bump golang.org/x/sys from 0.26.0 to 0.27.0 (#5118)b46ad10
docs: improve forbidigo pattern examples for built-in functions (#5116)8c0c515
fix: Go version propagation (#5109)874a8ba
feat: deprecation step 2 of execinquery and gomnd (#5110)6ba5f63
build(deps): bump github.com/mgechev/revive from 1.4.0 to 1.5.0 (#5113)c4b6d37
build(deps): bump github.com/nunnatsa/ginkgolinter from 0.17.0 to 0.18.0 (#5114)7560b4f
fix: improve Go detection (#5112)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)