Build e2e and integration test images as part of PR checks

[jsliacan]

Fixes: Issue #3931

Introduce a GH workflow with 2 jobs (run in parallel by default). 1 job builds e2e image and the other builds integration image. Both images are tagged with id-${{github.sha}}, archived as .tar files and uploaded as artifacts (instead of pushing to external registry). The purpose of these images is tied to the lifetime of a PR anyways.

These artifacts will be consumed by another workflow (windows-e2e/integration) which will use them to run e2e and integration PR checks on windows environment.

Note
Using ${{github.sha}} as the correlation number should work for both pull_request and push to main trigger events. For this, I have 2 github context dumps for each case (PR, push). Two workflows (test1 and test2) were triggered by the same event (PR or push to main) and context dump was saved. Comparing github.sha values suggests that they are the same for these workflows (as they should be). This generalizes the previous approach where we used PR# to correlate workflows. Moreover, the sha approach comes with another advantage. The sha changes from trigger to trigger, making sure that if we download an artifact with the correct sha, it will be the intended one and not one from a previous trigger. This would not be guaranteed when using PR# as id, because that does not change from trigger to trigger.

• on pull 1
• on pull 2
• on push 1
• on push 2

gha-win-e2e.pdf

[cfergeau]

Good to have CI for these container images as sometimes we use wrong base images in these, which cause build failures we only notice fairly late.

[adrianriobo]

why are you login?

[jsliacan]

Because I missed it when changing the flow. Mistake, removed. Thanks!

[adrianriobo]

Why some steps use the ${{ github.event.number }} directly and others use then env section?

[adrianriobo]

Also may build and save can be added together on a single step? it will make things a bit easier to read IMHO

[adrianriobo]

Would change to Upload e2e image (to match previous naming convention for steps)

[openshift-ci]

@jsliacan: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-crc	83df475	link	true	/test e2e-crc
ci/prow/integration-crc	83df475	link	true	/test integration-crc
ci/prow/e2e-microshift-crc	83df475	link	true	/test e2e-microshift-crc

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adrianriobo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [adrianriobo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment