actions: add windows e2e #3891
Merged
actions: add windows e2e #3891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsliacan
force-pushed
the
win-ci-check
branch
5 times, most recently
from
41910d8 to
f732e73
Compare
|
Is this a [WIP] or ready for review PR? |
|
@praveenkumar it's just the bot casually removing the |
jsliacan
force-pushed
the
win-ci-check
branch
17 times, most recently
from
547365c to
cdd27ed
Compare
jsliacan
force-pushed
the
win-ci-check
branch
16 times, most recently
from
1ab1f2b to
6b44a8c
Compare
jsliacan
force-pushed
the
win-ci-check
branch
2 times, most recently
from
a2fd5d2 to
ae5fed1
Compare
2019 installer is not needed and each entry of the matrix triggers a separate e2e workflow. So it is good to only have a 1x1 matrix.
We want to keep track of something unique to the trigger-event (that is the same across all actions triggered by that event that particular time). Given that an event triggered a chain of workflows, first workflow in the chain can access the trigger event, but later workflows can't. Saving something like shared commit-sha (correlation-id of sorts) as artifact will help us keep track of that. This information is contained in github context, so we save the whole json.
jsliacan
force-pushed
the
win-ci-check
branch
from
ae5fed1 to
7628257
Compare
jsliacan
force-pushed
the
win-ci-check
branch
from
7628257 to
c39e743
Compare
jsliacan
force-pushed
the
win-ci-check
branch
from
c39e743 to
f195e70
Compare
|
@jsliacan: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: Issue #3961