Use 'Apple silicon' instead of 'M1' #3890
Conversation
| @@ -14,9 +14,9 @@ import ( | |||
| var vfkitPreflightChecks = []Check{ | |||
| { | |||
| configKeySuffix: "check-m1-cpu", | |||
| checkDescription: "Checking if running emulated on a M1 CPU", | |||
| checkDescription: "Checking if running emulated on Apple silicon", | |||
| check: checkM1CPU, | |||
There was a problem hiding this comment.
can we change this check also to checkMseriesCPU or checkSiliconCPU ?
There are now M2 CPUs, and more generations to come. "Apple silicon" is more generic. This fixes crc-org#3889
| fixDescription: "This version of CRC for AMD64/Intel64 CPUs is unsupported on Apple M1 hardware", | ||
| checkDescription: "Checking if running emulated on Apple silicon", | ||
| check: checkAppleSilicon, | ||
| fixDescription: "This version of CRC for AMD64/Intel64 CPUs is unsupported on Apple silicon", |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: praveenkumar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@cfergeau: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
There are now M2 CPUs, and more generations to come. "Apple silicon" is
more generic.
This fixes #3889