ci: Use pre-built e2e/integration test binaries #3876
Conversation
When testing in prow, we currently use pre-built crc binaries on the node running the test, but the e2e.test/integration.test binaries are rebuilt on the node running the test. This is problematic because the GCP image used has an older golang (1.19) version than the builder used for the crc code. This will cause issues if we add code to crc which requires golang 1.20+, which will happen when we update the gvisor-tap-vsock code. These tests will have to be adjusted to take this change into account: https://github.com/openshift/release/blob/master/ci-operator/step-registry/code-ready/crc/microshift/test/code-ready-crc-microshift-test-commands.sh https://github.com/openshift/release/blob/master/ci-operator/step-registry/code-ready/crc/e2e/test/code-ready-crc-e2e-test-commands.sh https://github.com/openshift/release/blob/master/ci-operator/step-registry/code-ready/crc/integration/test/code-ready-crc-integration-test-commands.sh
This image is only used to create a GCP/azure instance and copy files to it, it does not need to have libvirt or genisoimage installed.
The image only needs packages which are available in ubi9/external repos, so we can switch to ubi9 for the image we run in openshift-ci.
The e2e tests already indirectly depend on the github.com/crc-org/pkg/crc/version go package, and the correct build flags are used to build it. Instead of setting VERSION_TO_TEST from flags in the Makefile, we can directly set it from the go code. This will check that the crc binary we use is the expected one. The check can still be disabled with `--crc-version=""`
The Makefile uses a variable named MODULEPATH for the name of the crc go module. It currently can be overridden with an env var, but I don't think this was ever tested, and this causes issues as some recent fedora package sets MODULEPATH in the env. This commit drops the environment override for MODULEPATH. This should fix crc-org#3865
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@cfergeau: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
This PR is a pre-requisite for #3861
When testing in prow, we currently use pre-built crc binaries on the
node running the test, but the e2e.test/integration.test binaries are rebuilt on the node
running the test.
This is problematic because the GCP image used has an older golang
(1.19) version than the builder used for the crc code. This will cause
issues if we add code to crc which requires golang 1.20+, which will
happen when we update the gvisor-tap-vsock code.
This PR uses test binaries built at the same time as the
crcbinary used fortesting, and does misc cleanups to the image which we are using to create our
GCP instance.