Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Antora extension setting some AsciiDoc attributes #3836

Merged
merged 1 commit into from
Sep 26, 2023

Conversation

themr0c
Copy link
Contributor

@themr0c themr0c commented Sep 12, 2023

Generate version related AsciiDoc attributes at build time rather than maintaining the values in the antora-playbook.yml file

The Antora extension:

  1. Gets the version from the Makefile.
  2. Sets the AsciiDoc attributes.

fixes #3829

@openshift-ci
Copy link

openshift-ci bot commented Sep 12, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@themr0c themr0c force-pushed the get-variables-from-file branch 2 times, most recently from 2dff30c to 7ba25b6 Compare September 12, 2023 09:40
@themr0c themr0c marked this pull request as ready for review September 12, 2023 14:23
@themr0c themr0c changed the title [draft] docs: Antora extension setting some AsciiDoc attributes docs: Antora extension setting some AsciiDoc attributes Sep 13, 2023
@themr0c
Copy link
Contributor Author

themr0c commented Sep 13, 2023

/retest

@themr0c themr0c requested a review from gbraad September 13, 2023 10:13
@openshift-ci
Copy link

openshift-ci bot commented Sep 13, 2023

@themr0c: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/integration-crc 80f5da4 link true /test integration-crc

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@themr0c
Copy link
Contributor Author

themr0c commented Sep 13, 2023

This could be another route: setting attributes from a YAML file: https://github.com/redpanda-data/docs-extensions-and-macros/blob/main/extensions/add-global-attributes.js

@openshift-ci
Copy link

openshift-ci bot commented Sep 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gbraad

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gbraad
Copy link
Contributor

gbraad commented Sep 18, 2023

please @praveenkumar check if these are the expected fields

antora-playbook.yml Outdated Show resolved Hide resolved
@openshift-ci
Copy link

openshift-ci bot commented Sep 26, 2023

New changes are detected. LGTM label has been removed.

…ject the result as AsciiDoc attributes

Signed-off-by: Fabrice Flore-Thébault <[email protected]>
@themr0c themr0c force-pushed the get-variables-from-file branch from 920aaa1 to 93f1462 Compare September 26, 2023 09:00
@themr0c
Copy link
Contributor Author

themr0c commented Sep 26, 2023

Rebased and squashed.

@praveenkumar praveenkumar merged commit 18cdd4a into crc-org:main Sep 26, 2023
10 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add included tools version metadata in the bundles
4 participants