-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Antora extension setting some AsciiDoc attributes #3836
Conversation
Skipping CI for Draft Pull Request. |
2dff30c
to
7ba25b6
Compare
/retest |
@themr0c: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
This could be another route: setting attributes from a YAML file: https://github.com/redpanda-data/docs-extensions-and-macros/blob/main/extensions/add-global-attributes.js |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gbraad The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
please @praveenkumar check if these are the expected fields |
80f5da4
to
920aaa1
Compare
New changes are detected. LGTM label has been removed. |
…ject the result as AsciiDoc attributes Signed-off-by: Fabrice Flore-Thébault <[email protected]>
920aaa1
to
93f1462
Compare
Rebased and squashed. |
Generate version related AsciiDoc attributes at build time rather than maintaining the values in the
antora-playbook.yml
fileThe Antora extension:
fixes #3829