Add libhvee as alternative Hyper-V driver on Windows #3824

gbraad · 2023-09-06T10:20:42Z

Basic functionality for:

create
start
stop
delete

adrianriobo · 2023-10-05T19:30:23Z

These are the results for this PR on windows https://crcqe-asia.s3.amazonaws.com/nightly/ocp/4.13.12/20231005/11-pro/qe-results/e2e-non-ux.xml all green except the known issue with the latest version for the pipelines operator

gbraad · 2023-10-06T09:49:21Z

Want to incorporate 9P, but the current codebase for this lives in the PR containers/gvisor-tap-vsock#280

cfergeau · 2023-10-06T10:31:52Z

Want to incorporate 9P, but the current codebase for this lives in the PR containers/gvisor-tap-vsock#280

The code from this gvisor-tap-vsock PR is short, and thus easy to add to the daemon when we need it. But there's also some guest code involved, which might be trickier mheon/libpod@334e213

gbraad · 2023-10-06T15:04:22Z

@cfergeau it basically is the same/similar code as the 9p-ufs that I tested with earlier, so I am not so concerned. I am more curious if this will therefore be part of a library, or the changes for libpod remain seperate?

gbraad · 2023-10-17T06:28:41Z

ref: #3870

cfergeau

I've rebased this and squashed the commits in https://github.com/cfergeau/crc/tree/libhvee
This looks like a fairly straightforward change, though I haven't tried running it on a Windows machine :)

cfergeau · 2023-10-31T16:24:57Z

pkg/crc/preflight/preflight_checks_windows.go

@@ -166,19 +165,6 @@ func fixUserPartOfCrcUsersAndHypervAdminsGroup() error {
 	return errReboot
 }

-func checkIfHyperVVirtualSwitchExists() error {


Fwiw, it would be good to split the system mode networking removal on Windows in its own preparatory commit, this would make it easier to focus on/review the config/preflight changes.

Honestly, I do not even know if this functionality still works. I'll consider, but these checks are also performed when not even necessary (like the existence of the virtual switch) and therefore actually wrong.

I've done this in https://github.com/cfergeau/crc/tree/libhvee, this removes even more code

pkg/drivers/libhvee/libhvee_windows.go

cfergeau · 2024-06-18T11:28:21Z

Everlasting rebasing

Rebase done.

gbraad · 2024-09-19T12:59:00Z

@lilyLuLiu @adrianriobo For this change, the proxy tests are failing. Do we have more information aroudn this?

adrianriobo · 2024-09-19T13:39:06Z

@gbraad those are mainly failing due to timeout on the full suite, let me check downstream running only that one I will ack if it is green (and will increase the timeout for the suite here)

lilyLuLiu · 2024-09-20T05:45:02Z

Downstream windows test passed for this PR.

adrianriobo · 2024-09-20T07:30:55Z

~~🙏 hold till today mid day need to check something else~~

We are good to go, downstream proxy is green

Should return an error when trying to set the "system networking" option. But I think this is already the case, or it's not possible to choose this option in release builds? Signed-off-by: Christophe Fergeau <[email protected]>

This replaces the interaction of Hyper-V from our machine-drivers based driver as used in Minikube/minishift to the libhvee library as used by podman machine.

Disk handling API was added to libhvee since the first iteration of the libhvee support, we can now make use of it. Signed-off-by: Christophe Fergeau <[email protected]>

adrianriobo

Full green on downstream windows env

openshift-ci · 2024-09-20T11:04:10Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adrianriobo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [adrianriobo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

cfergeau · 2024-09-20T11:06:02Z

Full green on downstream windows env

Didn't we wait too long though? We held this PR a while back as we did not want to land it at the same time as the switch to 4.16.
The next crc release could be 4.17-based, should we delay this again by one release?

openshift-ci · 2024-09-20T11:07:51Z

New changes are detected. LGTM label has been removed.

openshift-ci · 2024-09-20T13:43:06Z

@gbraad: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/security	`3003fc5`	link	false	`/test security`
ci/prow/integration-crc	`3003fc5`	link	true	`/test integration-crc`
ci/prow/e2e-crc	`3003fc5`	link	true	`/test e2e-crc`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

praveenkumar · 2024-09-23T05:37:59Z

Full green on downstream windows env

Didn't we wait too long though? We held this PR a while back as we did not want to land it at the same time as the switch to 4.16. The next crc release could be 4.17-based, should we delay this again by one release?

Since it is pass the pipeline, I don't think we should hold it any longer. I am merging this now.

cfergeau · 2024-09-23T07:59:46Z

Since it is pass the pipeline, I don't think we should hold it any longer. I am merging this now.

We held it last time because QE had concerns about their capacity to deal with 2 large changes at once, would have been nice to wait for their input before merging this..

adrianriobo · 2024-09-23T08:09:42Z

No worries, I am fine with it, as @praveenkumar this already passed (and actually has been passing for a while now). So I think we should be good.

gbraad · 2024-09-26T06:26:45Z

Thank you all

openshift-ci bot added the do-not-merge/work-in-progress label Sep 6, 2023

openshift-ci bot requested review from anjannath and evidolob September 6, 2023 10:20

gbraad force-pushed the gbraad/spike-add-libhvee-as-alternative-3811 branch 6 times, most recently from 9c10def to 2e72ce2 Compare September 11, 2023 06:51

gbraad changed the title ~~[WIP] fixes #3811 add libhvee as alternative Hyper-V driver on Windows~~ Add libhvee as alternative Hyper-V driver on Windows Sep 11, 2023

openshift-ci bot removed the do-not-merge/work-in-progress label Sep 11, 2023

gbraad force-pushed the gbraad/spike-add-libhvee-as-alternative-3811 branch from 0a919ec to 6013d5f Compare September 13, 2023 06:54

This comment was marked as outdated.

Sign in to view

gbraad force-pushed the gbraad/spike-add-libhvee-as-alternative-3811 branch from 6013d5f to d1658c1 Compare September 13, 2023 08:13

gbraad added points/3 priority/major os/windows labels Sep 19, 2023

gbraad self-assigned this Sep 19, 2023

gbraad requested review from praveenkumar and cfergeau September 19, 2023 10:29

openshift-merge-robot added the needs-rebase label Oct 6, 2023

gbraad mentioned this pull request Oct 6, 2023

Add support for volume sharing via gvproxy for HyperV containers/gvisor-tap-vsock#280

Closed

cfergeau reviewed Oct 31, 2023

View reviewed changes

gbraad mentioned this pull request Nov 2, 2023

Removing unneeded code containers/libhvee#59

Merged

gbraad changed the title ~~Add libhvee as alternative Hyper-V driver on Windows~~ [WIP] Add libhvee as alternative Hyper-V driver on Windows Nov 29, 2023

openshift-merge-robot removed the needs-rebase label Jun 18, 2024

cfergeau force-pushed the gbraad/spike-add-libhvee-as-alternative-3811 branch from 729ee25 to 3def960 Compare June 18, 2024 11:44

cfergeau force-pushed the gbraad/spike-add-libhvee-as-alternative-3811 branch 2 times, most recently from 17ce677 to ee4795d Compare September 11, 2024 03:49

openshift-merge-robot added the needs-rebase label Sep 20, 2024

cfergeau and others added 3 commits September 20, 2024 11:28

windows: Remove system networking

4866c23

Should return an error when trying to set the "system networking" option. But I think this is already the case, or it's not possible to choose this option in release builds? Signed-off-by: Christophe Fergeau <[email protected]>

Use libhvee instead of the current PowerShell cmdlet implementation

9d5bab2

This replaces the interaction of Hyper-V from our machine-drivers based driver as used in Minikube/minishift to the libhvee library as used by podman machine.

libhvee: Use libhvee APIs for disk resize

3003fc5

Disk handling API was added to libhvee since the first iteration of the libhvee support, we can now make use of it. Signed-off-by: Christophe Fergeau <[email protected]>

adrianriobo approved these changes Sep 20, 2024

View reviewed changes

openshift-ci bot assigned adrianriobo Sep 20, 2024

openshift-ci bot added the lgtm label Sep 20, 2024

openshift-ci bot added the approved label Sep 20, 2024

cfergeau force-pushed the gbraad/spike-add-libhvee-as-alternative-3811 branch from ee4795d to 3003fc5 Compare September 20, 2024 11:07

openshift-ci bot removed the lgtm label Sep 20, 2024

openshift-merge-robot removed the needs-rebase label Sep 20, 2024

praveenkumar merged commit d6c6e90 into main Sep 23, 2024
22 of 30 checks passed

gbraad deleted the gbraad/spike-add-libhvee-as-alternative-3811 branch September 26, 2024 06:26

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add libhvee as alternative Hyper-V driver on Windows #3824

Add libhvee as alternative Hyper-V driver on Windows #3824

gbraad commented Sep 6, 2023 •

edited

Loading

This comment was marked as outdated.

adrianriobo commented Oct 5, 2023 •

edited

Loading

gbraad commented Oct 6, 2023

cfergeau commented Oct 6, 2023

gbraad commented Oct 6, 2023

gbraad commented Oct 17, 2023

cfergeau left a comment

cfergeau Oct 31, 2023

gbraad Jan 24, 2024

cfergeau Apr 8, 2024

cfergeau commented Jun 18, 2024

gbraad commented Sep 19, 2024

adrianriobo commented Sep 19, 2024

lilyLuLiu commented Sep 20, 2024

adrianriobo commented Sep 20, 2024 •

edited

Loading

adrianriobo left a comment

openshift-ci bot commented Sep 20, 2024

cfergeau commented Sep 20, 2024

openshift-ci bot commented Sep 20, 2024

openshift-ci bot commented Sep 20, 2024

praveenkumar commented Sep 23, 2024

cfergeau commented Sep 23, 2024

adrianriobo commented Sep 23, 2024

gbraad commented Sep 26, 2024

Add libhvee as alternative Hyper-V driver on Windows #3824

Add libhvee as alternative Hyper-V driver on Windows #3824

Conversation

gbraad commented Sep 6, 2023 • edited Loading

This comment was marked as outdated.

adrianriobo commented Oct 5, 2023 • edited Loading

gbraad commented Oct 6, 2023

cfergeau commented Oct 6, 2023

gbraad commented Oct 6, 2023

gbraad commented Oct 17, 2023

cfergeau left a comment

Choose a reason for hiding this comment

cfergeau Oct 31, 2023

Choose a reason for hiding this comment

gbraad Jan 24, 2024

Choose a reason for hiding this comment

cfergeau Apr 8, 2024

Choose a reason for hiding this comment

cfergeau commented Jun 18, 2024

gbraad commented Sep 19, 2024

adrianriobo commented Sep 19, 2024

lilyLuLiu commented Sep 20, 2024

adrianriobo commented Sep 20, 2024 • edited Loading

adrianriobo left a comment

Choose a reason for hiding this comment

openshift-ci bot commented Sep 20, 2024

cfergeau commented Sep 20, 2024

openshift-ci bot commented Sep 20, 2024

openshift-ci bot commented Sep 20, 2024

praveenkumar commented Sep 23, 2024

cfergeau commented Sep 23, 2024

adrianriobo commented Sep 23, 2024

gbraad commented Sep 26, 2024

gbraad commented Sep 6, 2023 •

edited

Loading

adrianriobo commented Oct 5, 2023 •

edited

Loading

adrianriobo commented Sep 20, 2024 •

edited

Loading