-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
QA: Add EOL/deprecation warning about support for SQLAlchemy 1.3 #503
Conversation
3183efc
to
f58c33d
Compare
ecb77ba
to
2913ca9
Compare
With SQLAlchemy 2 around the corner, this will be even more imminent. | ||
Future versions of the CrateDB SQLAlchemy dialect will drop support for SQLAlchemy 1.3. | ||
It is recommended that you transition to using SQLAlchemy 1.4 or 2.0. | ||
""".lstrip("\n")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2.0 was released stable last night, and 1.3 is now officially EOL as per the "release status" table on https://www.sqlalchemy.org/download.html.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I've adjusted the admonition text correspondingly, and asked you and @hlcianfagna for another review. Thanks in advance!
2913ca9
to
1f5b2af
Compare
1f5b2af
to
88caf14
Compare
Introduction
We decided to drop support for SQLAlchemy 1.3 within one of the upcoming releases and are tracking this at crate/sqlalchemy-cratedb#85.
About
This patch adds a corresponding EOL/deprecation warning to the package, which will be emitted at runtime when running the Python interpreter with default warnings enabled 12.
Footnotes
https://docs.python.org/3/library/warnings.html#updating-code-for-new-versions-of-dependencies ↩
https://docs.python.org/3/using/cmdline.html#cmdoption-W ↩