Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QA: Add EOL/deprecation warning about support for SQLAlchemy 1.3 #503

Merged
merged 1 commit into from
Jan 27, 2023

Conversation

amotl
Copy link
Member

@amotl amotl commented Jan 26, 2023

Introduction

We decided to drop support for SQLAlchemy 1.3 within one of the upcoming releases and are tracking this at crate/sqlalchemy-cratedb#85.

About

This patch adds a corresponding EOL/deprecation warning to the package, which will be emitted at runtime when running the Python interpreter with default warnings enabled 12.

python -Wd -c "import crate.client.sqlalchemy"
PYTHONWARNINGS=default python -c "import crate.client.sqlalchemy"
/path/to/crate/client/sqlalchemy/__init__.py:38: DeprecationWarning: WARNING: SQLAlchemy 1.3 is effectively EOL.
With SQLAlchemy 2 around the corner, this will be even more immanent.
Future versions of the CrateDB SQLAlchemy dialect will drop support for SQLAlchemy 1.3.
It is recommended that you transition to using SQLAlchemy 1.4 or 2.0.

Footnotes

  1. https://docs.python.org/3/library/warnings.html#updating-code-for-new-versions-of-dependencies

  2. https://docs.python.org/3/using/cmdline.html#cmdoption-W

@amotl amotl force-pushed the amo/sa13-deprecation-warning branch from 3183efc to f58c33d Compare January 26, 2023 11:49
@amotl amotl marked this pull request as ready for review January 26, 2023 12:06
@hlcianfagna hlcianfagna force-pushed the amo/sa13-deprecation-warning branch from ecb77ba to 2913ca9 Compare January 26, 2023 13:13
@hlcianfagna
Copy link
Contributor

@amotl please check if the change I made on 2913ca9 makes sense

With SQLAlchemy 2 around the corner, this will be even more imminent.
Future versions of the CrateDB SQLAlchemy dialect will drop support for SQLAlchemy 1.3.
It is recommended that you transition to using SQLAlchemy 1.4 or 2.0.
""".lstrip("\n"))
Copy link
Member

@hammerhead hammerhead Jan 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2.0 was released stable last night, and 1.3 is now officially EOL as per the "release status" table on https://www.sqlalchemy.org/download.html.

Copy link
Member Author

@amotl amotl Jan 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I've adjusted the admonition text correspondingly, and asked you and @hlcianfagna for another review. Thanks in advance!

@amotl amotl force-pushed the amo/sa13-deprecation-warning branch from 2913ca9 to 1f5b2af Compare January 27, 2023 10:20
@amotl amotl requested a review from hammerhead January 27, 2023 10:21
@amotl amotl force-pushed the amo/sa13-deprecation-warning branch from 1f5b2af to 88caf14 Compare January 27, 2023 10:32
@amotl amotl requested a review from hlcianfagna January 27, 2023 10:47
@amotl amotl merged commit 183a116 into master Jan 27, 2023
@amotl amotl deleted the amo/sa13-deprecation-warning branch January 27, 2023 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants