SQLAlchemy 2.0: Restore backward-compatibility with SQLAlchemy 1.3 #497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolve import of `declarative_base`. For SA13, it is in `sqlalchemy.ext.declarative`, while it is in `sqlalchemy.orm` on more recent versions of SA.
Note that this is on a best-effort basis. SQLAlchemy 2.0 will be mostly compatible with most SQLAlchemy 1.3 code which is not using any of the deprecated functionalities, modulo a few aspects. > It is possible to have code that is compatible with 2.0 and 1.3 at the > same time, you would just need to ensure you use the subset of > features and APIs that are common to both. This patch adds a small compatibility layer, which activates on SA13 only, and monkey-patches two spots where anomalies have been spotted.
amotl
force-pushed
the
amo/sa20-sa13-compat
branch
from
f20930f to
67a4cf2
Compare
This was referenced Dec 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
Compatibility module for running a subset of SQLAlchemy 2.0 programs on SQLAlchemy 1.3. By using monkey-patching, it can do two things:
exec_driver_sql()method to SQLAlchemy'sConnectionandEngine, forwarding toexecute().sql.select()function to accept the calling semantics of the modern variant.Reason
After modernizing the code base,
exec_driver_sqlnow is used within the CrateDB dialect, and the new calling semantics ofsql.selectare used within many of the test cases already.Notes
Please note that the patch for
sql.selectis only applied when running the test suite.References