CI: Fix installation of defined SQLAlchemy version, bringing back SA13

.github/workflows/tests.yml

@@ -47,6 +47,9 @@ jobs:
           # Bootstrap environment.
           source bootstrap.sh
 
+          # Report about the test matrix slot.
+          echo "Invoking tests with CrateDB ${CRATEDB_VERSION} and SQLAlchemy ${SQLALCHEMY_VERSION}"
+
           # Invoke validation tasks.
           flake8 src bin
           coverage run bin/test -vv1

bootstrap.sh

@@ -65,6 +65,15 @@ function setup_package() {
     # Install package in editable mode.
     pip install --editable='.[sqlalchemy,test,doc]'
 
+    # Install designated SQLAlchemy version.
+    if [ -n "${SQLALCHEMY_VERSION}" ]; then
+      if [ "${SQLALCHEMY_VERSION}" = "latest" ]; then
+        pip install "sqlalchemy" --upgrade
+      else
+        pip install "sqlalchemy==${SQLALCHEMY_VERSION}"
+      fi
+    fi
+
 }
 
 function run_buildout() {

devtools/setup_ci.sh

@@ -10,20 +10,6 @@ function main() {
     echo "Environment variable 'CRATEDB_VERSION' needed"
     exit 1
   }
-  [ -z ${SQLALCHEMY_VERSION} ] && {
-    echo "Environment variable 'SQLALCHEMY_VERSION' needed"
-    exit 1
-  }
-
-  # Let's go.
-  echo "Invoking tests with CrateDB ${CRATEDB_VERSION} and SQLAlchemy ${SQLALCHEMY_VERSION}"
-
-  # Install designated SQLAlchemy version.
-  if [ ${SQLALCHEMY_VERSION} = "latest" ]; then
-    pip install "sqlalchemy" --upgrade
-  else
-    pip install "sqlalchemy==${SQLALCHEMY_VERSION}"
-  fi
 
   # Replace CrateDB version.
   if [ ${CRATEDB_VERSION} = "nightly" ]; then

src/crate/client/sqlalchemy/tests/compiler_test.py

@@ -26,6 +26,7 @@
 import sqlalchemy as sa
 from sqlalchemy.sql import update, text
 
+from crate.client.sqlalchemy.sa_version import SA_VERSION, SA_1_4
 from crate.client.sqlalchemy.types import Craty
 
 
@@ -77,7 +78,10 @@ def test_select_with_offset(self):
         self.metadata.bind = self.crate_engine
         selectable = self.mytable.select().offset(5)
         statement = str(selectable.compile())
-        self.assertEqual(statement, "SELECT mytable.name, mytable.data \nFROM mytable\n LIMIT ALL OFFSET ?")
+        if SA_VERSION >= SA_1_4:
+            self.assertEqual(statement, "SELECT mytable.name, mytable.data \nFROM mytable\n LIMIT ALL OFFSET ?")
+        else:
+            self.assertEqual(statement, "SELECT mytable.name, mytable.data \nFROM mytable \n LIMIT ALL OFFSET ?")
 
     def test_select_with_limit(self):
         """