Skip to content

Commit

Permalink
Merge pull request #68 from epage/template
Browse files Browse the repository at this point in the history
chore: Update from _rust template
  • Loading branch information
epage authored Sep 27, 2024
2 parents b3eb07c + fb86b69 commit c7debf8
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 5 deletions.
2 changes: 2 additions & 0 deletions .github/workflows/pre-commit.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,4 +24,6 @@ jobs:
steps:
- uses: actions/checkout@v4
- uses: actions/setup-python@v5
with:
python-version: '3.x'
- uses: pre-commit/[email protected]
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ We ask that commits are atomic, meaning they are complete and have a single resp
PRs should tell a cohesive story, with test and refactor commits that keep the
fix or feature commits simple and clear.

Specifically, we would encouage
Specifically, we would encourage
- File renames be isolated into their own commit
- Add tests in a commit before their feature or fix, showing the current behavior.
The diff for the feature/fix commit will then show how the behavior changed,
Expand Down
1 change: 1 addition & 0 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,7 @@ string_lit_as_bytes = "warn"
string_to_string = "warn"
todo = "warn"
trait_duplication_in_bounds = "warn"
uninlined_format_args = "warn"
verbose_file_reads = "warn"
wildcard_imports = "warn"
zero_sized_map_values = "warn"
Expand Down
7 changes: 3 additions & 4 deletions src/commit.rs
Original file line number Diff line number Diff line change
Expand Up @@ -125,13 +125,13 @@ impl fmt::Display for Commit<'_> {
f.write_str(self.type_().as_str())?;

if let Some(scope) = &self.scope() {
f.write_fmt(format_args!("({})", scope))?;
f.write_fmt(format_args!("({scope})"))?;
}

f.write_fmt(format_args!(": {}", &self.description()))?;

if let Some(body) = &self.body() {
f.write_fmt(format_args!("\n\n{}", body))?;
f.write_fmt(format_args!("\n\n{body}"))?;
}

for footer in self.footers() {
Expand Down Expand Up @@ -240,8 +240,7 @@ impl FromStr for FooterSeparator {
":" => Ok(FooterSeparator::Value),
" #" => Ok(FooterSeparator::Ref),
_ => {
Err(Error::new(ErrorKind::InvalidFooter)
.set_context(Box::new(format!("{:?}", sep))))
Err(Error::new(ErrorKind::InvalidFooter).set_context(Box::new(format!("{sep:?}"))))
}
}
}
Expand Down

0 comments on commit c7debf8

Please sign in to comment.