Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dockerfile): Adjust cargo install path #403

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

PigeonF
Copy link
Contributor

@PigeonF PigeonF commented Oct 23, 2024

The root Cargo.toml file is a virtual manifest, which cargo refuses to cargo install. Specifying the path to the committed binary crate fixes the issue.

A similar fix was already merged for typos in crate-ci/typos#1059.

The root `Cargo.toml` file is a virtual manifest, which cargo refuses
to `cargo install`. Specifying the path to the `committed` binary crate
fixes the issue.
@coveralls
Copy link

Pull Request Test Coverage Report for Build 11486506278

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 5.517%

Totals Coverage Status
Change from base Build 11128006904: 0.0%
Covered Lines: 24
Relevant Lines: 435

💛 - Coveralls

@epage epage merged commit ed53d01 into crate-ci:master Oct 23, 2024
17 checks passed
@epage
Copy link
Collaborator

epage commented Oct 23, 2024

Thanks!

@PigeonF PigeonF deleted the PigeonF/push-tptvuxlroxqm branch October 23, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants