Fix #66 #67
Open
Fix #66 #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonhoo
reviewed
Oct 19, 2019
|
This is certainly one way to do it, but it's also not very satisfying. I just really with |
|
Stripped the extra commit off, but feel free to just close without merging if you're not really into this fix (which is totally understandable and I want workspace definable features too :) ). I just hacked it in to get my own builds working, figured I might as well share just in case. |
|
Thanks! I think we just need some time to gather thoughts around this before we decide one way or another. I'll leave it open for now. Appreciate you submitting it though 👍 |
…ci#66 Leaves --no-default-features step to build by default, but allows turning it off for workspaces. Fixes crate-ci#66
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.