Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow running additional setup steps post-install #32

Merged
merged 1 commit into from
Jul 16, 2019
Merged

Conversation

jonhoo
Copy link
Collaborator

@jonhoo jonhoo commented Jul 16, 2019

No description provided.

@jonhoo jonhoo requested a review from epage July 16, 2019 13:30
@epage
Copy link
Contributor

epage commented Jul 16, 2019

I'm curious, what is the requirement driving this? I don't see an issue referenced or a commit message that talks about this and I've not seen a need in any of my projects.

@jonhoo
Copy link
Collaborator Author

jonhoo commented Jul 16, 2019

The idea here is to allow projects with external dependencies to install them before the actual compilation takes place. For example, my research project Noria needs to install a package. I should arguably have opened an issue first and added an explanation to the PR, but was in a rush this morning 😅

@jonhoo
Copy link
Collaborator Author

jonhoo commented Jul 16, 2019

Separately, we really need to figure out how where we're going to document all these options (#15).

The idea here is to allow projects with external dependencies to install
them before the actual compilation takes place. For example, some
projects may need to install system packages or other dependencies
before they can be built.
@jonhoo jonhoo merged commit e127e2d into master Jul 16, 2019
@jonhoo jonhoo deleted the setup-steps branch July 16, 2019 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants