Dayoffset in rundown #1396

alex-Arc · 2024-12-18T22:33:09Z

No description provided.

coderabbitai · 2024-12-18T22:33:16Z

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

cpvalente

Thank you Alex, I agree that this changes will lead to a better experience dealing with this dataset

I think we are moving in a direction where the server is providing us more metadata. I suggest that we spend some time to cleanup typing and processes around this

apps/client/src/features/rundown/Rundown.tsx

apps/client/src/features/rundown/RundownEntry.tsx

apps/client/src/features/rundown/event-block/EventBlock.utils.ts

cpvalente · 2024-12-21T09:48:11Z

packages/types/src/definitions/core/OntimeEvent.type.ts

@@ -39,6 +39,7 @@ export type OntimeEvent = OntimeBaseEvent & {
  colour: string;
  revision: number;
  delay?: number; // calculated at runtime
+  dayOffset?: number; // calculated at runtime


suggestion: I wonder if we are starting to complicate our code base a bit with these types

would it be better to have a OntimePersistedEvent and an OntimeEvent, where the OntimeEventcontains all the stuff calculated in rundownCache?

Yeah that sounds like a good idea
I've been struggling a bit with the optional so making a new type would be great

Should we make a new type for pre or post cache.generate ?

I am not sure if I understood. but I think the two types we need are

one type with the base data we need, this is stored in the json file

one type with added metadata, this will be in all the runtime stores and generated in the rundownCache

should the "normal" OntimeEvent type be the on with meta data since that is what is being operated on in most of the code base, and then we create a new dbOntimeEvent with out the metadata?
some thing like this

I am not sure if there is something definitely better. I think your suggestion is good and makes sense

packages/utils/src/date-utils/getTimeFromPrevious.ts

cpvalente · 2024-12-21T09:52:08Z

apps/server/src/services/rundown-service/rundownCache.ts

        const timeFromPrevious: number = getTimeFromPrevious(
          currentEntry.timeStart,
+          currentEntry.dayOffset,


cleanup: we need to make sure that these properties do not get persisted. I have flagged the entrypoint for the code in this comment
https://github.com/cpvalente/ontime/blob/master/apps/server/src/services/rundown-service/rundownCache.ts#L97

Co-authored-by: Carlos Valente <[email protected]>

alex-Arc force-pushed the dayoffset-in-rundown branch from 1d3d448 to ba7b214 Compare December 20, 2024 17:03

cpvalente reviewed Dec 21, 2024

View reviewed changes

alex-Arc and others added 10 commits December 22, 2024 16:28

refactor: getTimeFromPrevious

516e285

calculate day offset in rundownCache

cc35490

refactor: isNewLatest

80a9a2b

refactor: timline use dayOffset

e95c09c

refactor: in client

deb9575

refactor: calc gap in rundown

6a7082a

gap display

4cd30be

test

5e23a88

jsdoc

1125598

Co-authored-by: Carlos Valente <[email protected]>

gapTime

0b4095b

alex-Arc force-pushed the dayoffset-in-rundown branch from eeb6603 to 0b4095b Compare December 22, 2024 15:28

alex-Arc changed the base branch from master to collection December 25, 2024 16:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Dayoffset in rundown #1396

Dayoffset in rundown #1396

alex-Arc commented Dec 18, 2024

coderabbitai bot commented Dec 18, 2024 •

edited

Loading

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

cpvalente left a comment

cpvalente Dec 21, 2024

alex-Arc Dec 21, 2024 •

edited

Loading

cpvalente Dec 21, 2024

alex-Arc Dec 21, 2024 •

edited

Loading

cpvalente Dec 22, 2024

cpvalente Dec 21, 2024

Dayoffset in rundown #1396

Are you sure you want to change the base?

Dayoffset in rundown #1396

Conversation

alex-Arc commented Dec 18, 2024

coderabbitai bot commented Dec 18, 2024 • edited Loading

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

cpvalente left a comment

Choose a reason for hiding this comment

cpvalente Dec 21, 2024

Choose a reason for hiding this comment

alex-Arc Dec 21, 2024 • edited Loading

Choose a reason for hiding this comment

cpvalente Dec 21, 2024

Choose a reason for hiding this comment

alex-Arc Dec 21, 2024 • edited Loading

Choose a reason for hiding this comment

cpvalente Dec 22, 2024

Choose a reason for hiding this comment

cpvalente Dec 21, 2024

Choose a reason for hiding this comment

coderabbitai bot commented Dec 18, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

alex-Arc Dec 21, 2024 •

edited

Loading

alex-Arc Dec 21, 2024 •

edited

Loading