-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python venv cache support #234
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to be clear, this may not cache the clang-format nor clang-tidy executables.
Important
This might actually cache the executables on MacOS or Windows because our cpp-linter/clang-tools-pip tool will fall back to installing clang tools (static) binaries to the same directory that the python executable is located.
In the case of a venv, that default install location is /.env/Scripts/ on Windows or /.env/bin/ on MacOS (~/.local/bin/ on linux).
FYI, I think the CI failed on MacOS runners because of segfaults. This isn't anything to do with the changes here, rather we should look into this separately. |
I also think there should be some logic added to detect presence of a cached venv before creating a venv. Line 241 in a3ed755
Line 277 in a3ed755
The above lines might fail if the venv folder already exists. |
I guess we should also cache pip's global cache as well if this new option is enabled. |
hashFiles
currently doesn't support globs outside of the GITHUB_WORKSPACE. This works around the limitation.