Release limit per dist #18
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… other query params) and include same in the sequence-generating sub-query. This is working for by_author, but not for distmat (see failing test).
|
This looks great. Thanks for the work you've done so far, and good luck in the new job. I'll try to take a look this week to see if I can break the impasse. |
preaction
force-pushed
the
master
branch
2 times, most recently
from
685ac04 to
22450a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is not to be merged; for review only.
@preaction As I've mentioned in IRC the technique of creating virtual "row numbers" with a subquery was not working, in the sense that it first assigned the sequence to releases, and then applied the other constraints. So a query for the most recent 4 releases of a dist, by_author X, might only return 3 results, if one of the most recent 4 releases were authored by Y.
This is solved in the case of
by_authorby passing that constraint into the sequence-generating sub-query, so only matching results are assigned a place in the sequence.However, the same technique is not working for
distmat(ie thematurityparam), even though the SQL looks right.I'm at a loss at the moment. And I start a new
$jobon Monday, and I have to do a bunch of boring admin work on a frikkin Drupal website I run for a club I'm in (sigh). So while I am not abandoning this issue, I wanted to post what I have so far so that if you have any time or desire, you can check it out and possibly even figure it out.