Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pre-commit.ci] pre-commit autoupdate #836

Merged
merged 2 commits into from
Sep 10, 2024
Merged

Conversation

pre-commit-ci[bot]
Copy link
Contributor

@pre-commit-ci pre-commit-ci bot commented Aug 19, 2024

@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch from fb11578 to f7735a2 Compare August 19, 2024 17:49
@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch 2 times, most recently from ed726fc to 35edd41 Compare September 2, 2024 17:49
@hfp
Copy link
Member

hfp commented Sep 3, 2024

My proposal is to remove all code related to prediction incl. the Jupyter notebook(s). This and future pre-commits like the Python linter rejects for instance src/acc/libsmm_acc/notebooks/inspect_training_data.ipynb. Without porting this code to new versions of their dependencies, the pre-commit remains red. An alternative is to exclude/green-list related failures. The real concern is the lack of testing for the prediction. Removing the code also fixes the security warning.

updates:
- [github.com/astral-sh/ruff-pre-commit: v0.5.7 → v0.6.4](astral-sh/ruff-pre-commit@v0.5.7...v0.6.4)
@alazzaro
Copy link
Member

OK, as a first step I will merge this PR, which will break the PR. Then I will check and merge #838 which will make the CI happy again ;)

@alazzaro alazzaro merged commit 05ea99d into develop Sep 10, 2024
20 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants