-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Update cozy-harvest-lib from 6.7.3
to 17.0.0
#2483
Open
Merkur39
wants to merge
3
commits into
master
Choose a base branch
from
feat/update-cozy-harvest-lib-to-17.0.0
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+5,181
−104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merkur39
force-pushed
the
feat/update-cozy-harvest-lib-to-17.0.0
branch
6 times, most recently
from
August 3, 2023 11:14
69dc702
to
3eafcc2
Compare
Merkur39
force-pushed
the
feat/update-cozy-harvest-lib-to-17.0.0
branch
5 times, most recently
from
August 4, 2023 09:27
a24370a
to
bdf9418
Compare
Merkur39
force-pushed
the
feat/update-cozy-harvest-lib-to-17.0.0
branch
from
August 4, 2023 10:04
bdf9418
to
9dc8e51
Compare
BundleMonFiles added (3)
Files removed (3)
No change in files bundle size Groups removed (1)
Final result: ✅ View report in BundleMon website ➡️ |
JF-Cozy
reviewed
Aug 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
est-ce que l'approche a été validé avec @Crash-- ?
Merkur39
force-pushed
the
feat/update-cozy-harvest-lib-to-17.0.0
branch
2 times, most recently
from
August 8, 2023 13:33
aca557f
to
31413ba
Compare
BREAKING CHANGE: Moved the `stylesheet.css` file to the `dist` folder, in order to group the style files. You must change your import: `import 'cozy-ui/transpiled/react/stylesheet.css'` by: `import 'cozy-ui/dist/stylesheet.css'`
BREAKING CHANGE: you must have `cozy-harvest-lib >= 17.0.0` & `cozy-client >= 40.2.0` To benefit from the fix cozy/cozy-libs@920f9d2
Following the update of some subdependencies, the `baseDir` parameter of the bundlemon configuration no longer works if it is not filled in or simply with `"."` or `"./"`. The `transpiled/react` folder now having only components, it is more relevant that it is on the application side that the components are monitored by Bundlemon.
Merkur39
force-pushed
the
feat/update-cozy-harvest-lib-to-17.0.0
branch
from
August 9, 2023 07:40
31413ba
to
bc36880
Compare
JF-Cozy
approved these changes
Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the update of some subdependencies, the
baseDir
parameter of the bundlemon configuration no longer works if it is not filled in or simply with"."
or"./"
.The
transpiled/react
folder now having only components, it is more relevant that it is on the application side that the components are monitored by Bundlemon.BREAKING CHANGE: Moved the
stylesheet.css
file to thedist
folder, in order to group the style files.You must change your import:
import 'cozy-ui/transpiled/react/stylesheet.css'
byimport 'cozy-ui/dist/stylesheet.css'
BREAKING CHANGE: you must have
cozy-harvest-lib >= 17.0.0
&cozy-client >= 40.2.0
To benefit from the fix cozy/cozy-libs@920f9d2