feat(sharing): Replace old sharing link menu with the new modal #2687
+1,071
−456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merkur39
requested review from
JF-Cozy,
Ldoppea,
zatteo and
doubleface
as code owners
zatteo
reviewed
Jan 7, 2025
packages/cozy-sharing/src/components/ShareRestrictionModal/BoxDate.jsx
Outdated
Show resolved
Hide resolved
zatteo
reviewed
Jan 7, 2025
zatteo
reviewed
Jan 7, 2025
packages/cozy-sharing/src/components/ShareRestrictionModal/helpers.spec.js
Show resolved
Hide resolved
|
I like the clean component separation 👏 |
Merkur39
force-pushed
the
feat/vo-1244
branch
3 times, most recently
from
bc73112 to
3ac8f2d
Compare
- Add cozy-minilog - Add date-fns - Update cozy-ui
Replacing share menu actions with links.
BREAKING CHANGE: You muse have `cozy-client >= 52.1.0` and `cozy-ui >= 116.0.0`
This component is not used anymore
zatteo
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link sharing has evolved: it will now be possible to add a validity date and/or a password to link shares.
The button no longer opens a menu directly, but a modal with more options.
Before:
After:
