Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Handle file upload from Flagship #2969
feat: Handle file upload from Flagship #2969
Changes from 13 commits
27bb930
d01f57c
63717e4
67a82ec
bebe91a
84d330d
a17bcf2
19f851d
4e5adda
94427c6
3038ca5
ce5928b
96ce541
f7eff39
c42e0db
d92c61c
fc7b072
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just noticed that we pass only one file at a time to
uploadFiles
. Didn't we want to pass an array here?If yes we should modify the interface.
If no we should rename this as
uploadFile
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes it's one by one, it was made like that to mimick the old upload to mobile feature. In this case renaming seems the best approach
done on react-native side too cozy/cozy-flagship-app@5278d76