Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Base: Add SwapRouter02 #3120

Merged
merged 4 commits into from
Nov 21, 2024
Merged

Base: Add SwapRouter02 #3120

merged 4 commits into from
Nov 21, 2024

Conversation

m-lord-renkse
Copy link
Contributor

Description

Add SwapRouter02 to Base, since SwapRouter is not available. The interface for the function we use (ExactOutputSingle) is the same for SwapRouter02 and SwapRouter.

@m-lord-renkse m-lord-renkse marked this pull request as ready for review November 12, 2024 14:40
@m-lord-renkse m-lord-renkse requested a review from a team as a code owner November 12, 2024 14:40
Copy link
Contributor

@fleupold fleupold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is my understanding correct that SwapRouter02 is the new contract that combines the v2 and v3 router?

I wonder if in this case it makes sense to update the deployments to all use the new router? But I guess we would still need the v2 router for Gnosis

crates/contracts/build.rs Show resolved Hide resolved
@m-lord-renkse
Copy link
Contributor Author

m-lord-renkse commented Nov 19, 2024

Is my understanding correct that SwapRouter02 is the new contract that combines the v2 and v3 router?

That is what I understand too. It definitely has the same interface for the call that we use.

I wonder if in this case it makes sense to update the deployments to all use the new router? But I guess we would still need the v2 router for Gnosis

Yeah, I was afraid of creating a mess by adding different versions. My idea was to first merge this one since it is just for Base, see how it works, and then update the rest. WDYT?

@m-lord-renkse m-lord-renkse merged commit 27e3c3b into main Nov 21, 2024
11 checks passed
@m-lord-renkse m-lord-renkse deleted the add-base-SwapRouter02 branch November 21, 2024 09:39
@github-actions github-actions bot locked and limited conversation to collaborators Nov 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants